What are the potential pitfalls of embedding functions in PHP strings?

Potential pitfalls of embedding functions in PHP strings include decreased readability, potential security vulnerabilities (such as SQL injection), and difficulty in debugging. To solve this issue, it is recommended to separate the function calls from the string concatenation to improve code maintainability and security.

// Incorrect way of embedding functions in PHP strings
$user_id = $_GET['user_id'];
$query = "SELECT * FROM users WHERE id = $user_id";

// Correct way of separating function calls from string concatenation
$user_id = $_GET['user_id'];
$query = "SELECT * FROM users WHERE id = " . mysqli_real_escape_string($connection, $user_id);