How can the code snippet be improved to adhere to better coding practices, such as separating login logic from user ID retrieval logic in PHP?

The code snippet can be improved by separating the login logic from the user ID retrieval logic. This separation helps in keeping the code modular, easier to read, and maintain. To achieve this, we can create a separate function for user ID retrieval that takes the username as a parameter and returns the corresponding user ID. 

function getUserIdByUsername($username, $db) {
    $query = "SELECT id FROM users WHERE username = :username";
    $stmt = $db->prepare($query);
    $stmt->bindParam(':username', $username);
    $stmt->execute();
    $result = $stmt->fetch();
    
    return $result['id'];
}

function login($username, $password, $db) {
    // Login logic here
}

// Example usage
$db = new PDO("mysql:host=localhost;dbname=myDB", "username", "password");
$username = "john_doe";
$userID = getUserIdByUsername($username, $db);

Keywords

PHP coding practices separation of concerns login logic user ID retrieval logic

Related Questions